jay/qmk_firmware_a
1
0
Fork 0
mirror of https://github.com/qmk/qmk_firmware.git synced 2026-06-03 14:13:46 -03:00
Code Issues Packages Projects Releases Wiki Activity

Promote duplication of defaults check to error (#26025)

Browse Source
This commit is contained in:
Joel Challis
2026-02-20 15:45:26 +00:00
committed by GitHub
parent 2d46c96732
commit 4733a2df16
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/python/qmk/cli/lint.py
+5 -2
View File
@@ -234,12 +234,15 @@ def _handle_duplicating_code_defaults(kb, info):
defaults_map = json_load(Path('data/mappings/info_defaults.hjson'))
dotty_info = dotty(info)
ok = True
for key, v_default in _collect_dotted_output(defaults_map):
v_info = dotty_info.get(key)
if v_default == v_info:
cli.log.warning(f'{kb}: Option "{key}" duplicates default value of "{v_default}"')
cli.log.error(f'{kb}: Option "{key}" duplicates default value of "{v_default}"')
ok = False
return True
return ok
def keymap_check(kb, km):