jay/qmk_firmware_a
1
0
Fork 0
mirror of https://github.com/qmk/qmk_firmware.git synced 2026-06-03 14:13:46 -03:00
Code Issues Packages Projects Releases Wiki Activity

Refactor core use of deprecated isLeftHand (#25888)

Browse Source
This commit is contained in:
Joel Challis
2025-12-21 20:52:55 +00:00
committed by GitHub
parent f82d4d8680
commit c1161a7a32
10 changed files with 33 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/encoder/encoder_quadrature.c
+4 -6
View File
@@ -27,8 +27,6 @@
# define ENCODER_DEFAULT_PIN_API_IMPL
#endif
extern volatile bool isLeftHand;
__attribute__((weak)) void encoder_quadrature_init_pin(uint8_t index, bool pad_b);
__attribute__((weak)) uint8_t encoder_quadrature_read_pin(uint8_t index, bool pad_b);
@@ -108,10 +106,10 @@ void encoder_quadrature_post_init(void) {
void encoder_driver_init(void) {
#ifdef SPLIT_KEYBOARD
thisHand = isLeftHand ? 0 : NUM_ENCODERS_LEFT;
thisHand = is_keyboard_left() ? 0 : NUM_ENCODERS_LEFT;
thatHand = NUM_ENCODERS_LEFT - thisHand;
thisCount = isLeftHand ? NUM_ENCODERS_LEFT : NUM_ENCODERS_RIGHT;
thatCount = isLeftHand ? NUM_ENCODERS_RIGHT : NUM_ENCODERS_LEFT;
thisCount = is_keyboard_left() ? NUM_ENCODERS_LEFT : NUM_ENCODERS_RIGHT;
thatCount = is_keyboard_left() ? NUM_ENCODERS_RIGHT : NUM_ENCODERS_LEFT;
#else // SPLIT_KEYBOARD
thisCount = NUM_ENCODERS;
#endif
@@ -133,7 +131,7 @@ void encoder_driver_init(void) {
#if defined(SPLIT_KEYBOARD) && defined(ENCODER_A_PINS_RIGHT) && defined(ENCODER_B_PINS_RIGHT)
// Re-initialise the pads if it's the right-hand side
if (!isLeftHand) {
if (!is_keyboard_left()) {
const pin_t encoders_pad_a_right[] = ENCODER_A_PINS_RIGHT;
const pin_t encoders_pad_b_right[] = ENCODER_B_PINS_RIGHT;
for (uint8_t i = 0; i < thisCount; i++) {