Remove FORCE_NKRO (#26206)

This commit is contained in:
Joel Challis
2026-05-16 02:27:19 +01:00
committed by GitHub
parent 2b88b7b20a
commit ce4f342ceb
16 changed files with 18 additions and 81 deletions
+1 -1
View File
@@ -269,9 +269,9 @@
"PRODUCT": {"info_key": "keyboard_name", "warn_duplicate": false, "value_type": "str", "deprecated": true, "replace_with": "`keyboard_name` in info.json"},
"PRODUCT_ID": {"info_key": "usb.pid", "value_type": "hex", "deprecated": true, "replace_with": "`usb.pid` in info.json"},
"VENDOR_ID": {"info_key": "usb.vid", "value_type": "hex", "deprecated": true, "replace_with": "`usb.vid` in info.json"},
"FORCE_NKRO": {"info_key": "usb.force_nkro", "value_type": "flag", "deprecated": true, "replace_with": "`host.default.nkro` in info.json"},
// Items we want flagged in lint
"FORCE_NKRO": {"info_key": "usb.force_nkro", "value_type": "flag", "invalid": true, "replace_with": "`host.default.nkro` in info.json"},
"VIAL_KEYBOARD_UID": {"info_key": "_invalid.vial_uid", "invalid": true},
"VIAL_UNLOCK_COMBO_COLS": {"info_key": "_invalid.vial_unlock_cols", "invalid": true},
"VIAL_UNLOCK_COMBO_ROWS": {"info_key": "_invalid.vial_unlock_rows", "invalid": true}
+1 -1
View File
@@ -91,7 +91,7 @@ Enables your LED to breath while your computer is sleeping. Timer1 is being used
`NKRO_ENABLE`
This allows the keyboard to tell the host OS that up to 248 keys are held down at once (default without NKRO is 6). NKRO is off by default, even if `NKRO_ENABLE` is set. NKRO can be forced by adding `#define FORCE_NKRO` to your config.h or by binding `MAGIC_TOGGLE_NKRO` to a key and then hitting the key.
This allows the keyboard to tell the host OS that up to 248 keys are held down at once (default without NKRO is 6). NKRO is off by default, even if `NKRO_ENABLE` is set. NKRO can be toggled by binding `NK_TOGG` to a key and then hitting the key.
`BACKLIGHT_ENABLE`
-25
View File
@@ -1,25 +0,0 @@
/*
This is the c configuration file for the keymap
Copyright 2012 Jun Wako <wakojun@gmail.com>
Copyright 2015 Jack Humbert
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#pragma once
//#define USE_I2C
#define FORCE_NKRO
+5
View File
@@ -14,6 +14,11 @@
"command": true,
"nkro": true
},
"host": {
"default": {
"nkro": true
}
},
"qmk": {
"locking": {
"enabled": true,
@@ -4,7 +4,6 @@ This layout replaces the stock layout on the Vortex Race 3.
- Caps Lock indicator LED is enabled by default
- Layer Tap on Caps Lock (tap for Caps Lock, hold for _FN1)
- FORCE_NKRO enabled by default
- Pn key is set to 'KC_NO' by default
* Might be a good place for a macro, or to put your PC to sleep, etc.
@@ -4,7 +4,6 @@ This layout replaces the stock layout on the Vortex Race 3.
- Caps Lock indicator LED is enabled by default
- Layer Tap on Caps Lock (tap for Caps Lock, hold for _FN1)
- FORCE_NKRO enabled by default
- Pn key is set to 'KC_NO' by default
* Might be a good place for a macro, or to put your PC to sleep, etc.
@@ -4,7 +4,6 @@ This layout replaces the stock layout on the Vortex Race 3.
- Caps Lock indicator LED is enabled by default
- Layer Tap on Caps Lock (tap for Caps Lock, hold for _FN1)
- FORCE_NKRO enabled by default
- Pn key is set to 'KC_NO' by default
* Might be a good place for a macro, or to put your PC to sleep, etc.
@@ -4,7 +4,6 @@ This layout replaces the stock layout on the Vortex Race 3.
- Caps Lock indicator LED is enabled by default
- Layer Tap on Caps Lock (tap for Caps Lock, hold for _FN1)
- FORCE_NKRO enabled by default
- Pn key is set to 'KC_NO' by default
* Might be a good place for a macro, or to put your PC to sleep, etc.
@@ -4,7 +4,6 @@ This layout replaces the stock layout on the Vortex Race 3.
- Caps Lock indicator LED is enabled by default
- Layer Tap on Caps Lock (tap for Caps Lock, hold for _FN1)
- FORCE_NKRO enabled by default
- Pn key is set to 'KC_NO' by default
* Might be a good place for a macro, or to put your PC to sleep, etc.
@@ -8,7 +8,7 @@
#undef PERMISSIVE_HOLD
#define FORCE_NKRO
#define NKRO_DEFAULT_ON true
#ifndef TAPPING_TOGGLE
#define TAPPING_TOGGLE 1
+5
View File
@@ -15,6 +15,11 @@
"nkro": true,
"rgblight": true
},
"host": {
"default": {
"nkro": true
}
},
"qmk": {
"locking": {
"enabled": true,
@@ -16,4 +16,3 @@
#pragma once
#define ONESHOT_TIMEOUT 2000
#define FORCE_NKRO
@@ -13,6 +13,11 @@
"mousekey": true,
"nkro": true
},
"host": {
"default": {
"nkro": true
}
},
"matrix_pins": {
"cols": ["C7", "C6", "B6", "B5", "B4", "D7", "D6", "D4"],
"rows": ["D5", "D3", "D2", "D1", "D0", "B7"]
@@ -1,21 +0,0 @@
/*
Copyright 2020 Ckat <ckat@teknik.io>
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#pragma once
/* ensure NKRO is on */
#define FORCE_NKRO
@@ -1,21 +0,0 @@
/*
Copyright 2020 Ckat <ckat@teknik.io>
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#pragma once
/* ensure NKRO is on */
#define FORCE_NKRO
-5
View File
@@ -510,11 +510,6 @@ void keyboard_init(void) {
#ifdef STENO_ENABLE_ALL
steno_init();
#endif
#if defined(NKRO_ENABLE) && defined(FORCE_NKRO)
# pragma message "FORCE_NKRO option is now deprecated - Please migrate to NKRO_DEFAULT_ON instead."
keymap_config.nkro = 1;
eeconfig_update_keymap(&keymap_config);
#endif
#ifdef DIP_SWITCH_ENABLE
dip_switch_init();
#endif